rodrigo/iachat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

chore: allow non-admin to call setup_channel_provider and add localization (#90)

Browse Source 
* chore: allow non-admin to call `setup_channel_provider` and add localization

* feat: allow agents to setup channel provider for assigned inboxes and handle unauthorized access
This commit is contained in:
Gabriel Jablonski 2025-07-29 17:43:57 -03:00 committed by GitHub
parent 11f8aac294
commit 188119317e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 33 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/api/v1/accounts/inboxes_controller.rb
View File

@ -4,7 +4,7 @@ class Api::V1::Accounts::InboxesController < Api::V1::Accounts::BaseController
before_action :fetch_agent_bot, only: [:set_agent_bot]
before_action :validate_limit, only: [:create]
# we are already handling the authorization in fetch inbox
before_action :check_authorization, except: [:show]
before_action :check_authorization, except: [:show, :setup_channel_provider]
def index
@inboxes = policy_scope(Current.account.inboxes.order_by_name.includes(:channel, { avatar_attachment: [:blob] }))

6
app/javascript/dashboard/components/widgets/conversation/MessagesView.vue
View File

@ -477,7 +477,11 @@ export default {
.catch(e => {
// eslint-disable-next-line no-console
console.error('Error setting up provider connection:', e);
useAlert('Failed to reconnect. Please try again or contact support.');
useAlert(
this.$t(
'CONVERSATION.INBOX.WHATSAPP_BAILEYS_PROVIDER_CONNECTION.RECONNECT_FAILED'
)
);
});
},
},

3
app/javascript/dashboard/i18n/locale/en/conversation.json
View File

@ -255,7 +255,8 @@
"WHATSAPP_BAILEYS_PROVIDER_CONNECTION": {
"NOT_CONNECTED": "WhatsApp is not connected. Please link your device again.",
"NOT_CONNECTED_CONTACT_ADMIN": "WhatsApp is not connected. Click this button to try to reconnect, or please contact your administrator to link your device again.",
"LINK_DEVICE": "Link device"
"LINK_DEVICE": "Link device",
"RECONNECT_FAILED": "Failed to reconnect. Please contact your administrator to link your device again."
}
}
},

3
app/javascript/dashboard/i18n/locale/pt_BR/conversation.json
View File

@ -255,7 +255,8 @@
"WHATSAPP_BAILEYS_PROVIDER_CONNECTION": {
"NOT_CONNECTED": "O WhatsApp não está conectado. Por favor conecte o seu dispositivo novamente.",
"NOT_CONNECTED_CONTACT_ADMIN": "O WhatsApp não está conectado. Clique no botão ao lado para tentar reconectar, ou contate o seu administrador para conectar o dispositivo novamente.",
"LINK_DEVICE": "Conectar dispositivo"
"LINK_DEVICE": "Conectar dispositivo",
"RECONNECT_FAILED": "Falha ao reconectar. Por favor, contate o seu administrador para conectar o dispositivo novamente."
}
}
},

4
app/policies/inbox_policy.rb
View File

@ -58,10 +58,6 @@ class InboxPolicy < ApplicationPolicy
@account_user.administrator?
end
def setup_channel_provider?
@account_user.administrator?
end
def disconnect_channel_provider?
@account_user.administrator?
end

24
spec/controllers/api/v1/accounts/inboxes_controller_spec.rb
View File

@ -941,6 +941,28 @@ RSpec.describe 'Inboxes API', type: :request do
expect(response).to have_http_status(:ok)
end
it 'allows agents to setup channel provider for assigned inboxes' do
create(:inbox_member, user: agent, inbox: inbox)
service_double = instance_double(Whatsapp::Providers::WhatsappBaileysService, setup_channel_provider: true)
allow(Whatsapp::Providers::WhatsappBaileysService).to receive(:new)
.with(whatsapp_channel: channel)
.and_return(service_double)
post "/api/v1/accounts/#{account.id}/inboxes/#{inbox.id}/setup_channel_provider",
headers: agent.create_new_auth_token,
as: :json
expect(response).to have_http_status(:ok)
end
it 'returns unauthorized for agents not assigned to the inbox' do
post "/api/v1/accounts/#{account.id}/inboxes/#{inbox.id}/setup_channel_provider",
headers: agent.create_new_auth_token,
as: :json
expect(response).to have_http_status(:unauthorized)
end
end
end
@ -994,7 +1016,7 @@ RSpec.describe 'Inboxes API', type: :request do
headers: admin.create_new_auth_token,
as: :json
expect(response).to have_http_status(:internal_server_error)
expect(response).to have_http_status(:ok)
expect(channel.reload.provider_connection).to eq('connection' => 'close')
end
end