rodrigo/iachat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix: Remove unnecessary attributes from notification deleted action cable event payload (#9295)

Browse Source 
fix: simplify notification deleted payload event
This commit is contained in:
Muhsin Keloth 2024-04-25 11:25:19 +05:30 committed by GitHub
parent 9086650fe2
commit 1bf3ad9a08
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/listeners/action_cable_listener.rb
View File

@ -18,7 +18,7 @@ class ActionCableListener < BaseListener
notification, account, unread_count, count = extract_notification_and_account(event) notification, account, unread_count, count = extract_notification_and_account(event)
tokens = [event.data[:notification].user.pubsub_token] tokens = [event.data[:notification].user.pubsub_token]
broadcast(account, tokens, NOTIFICATION_DELETED, { notification: notification.push_event_data, unread_count: unread_count, count: count }) broadcast(account, tokens, NOTIFICATION_DELETED, { notification: { id: notification.id }, unread_count: unread_count, count: count })
end end
def account_cache_invalidated(event) def account_cache_invalidated(event)

4
spec/listeners/action_cable_listener_spec.rb
View File

@ -142,7 +142,9 @@ describe ActionCableListener do
'notification.deleted', 'notification.deleted',
{ {
account_id: notification.account_id, account_id: notification.account_id,
notification: notification.push_event_data, notification: {
id: notification.id
},
unread_count: 1, unread_count: 1,
count: 1 count: 1
} }