From 37bf4b7dd809177c9309f8b1bcaa1052566ca24d Mon Sep 17 00:00:00 2001
From: Pascal Jufer <paescuj@users.noreply.github.com>
Date: Fri, 13 Aug 2021 15:40:47 +0200
Subject: [PATCH] fix: Use label for "Subscribe to updates" checkbox (#2788)

---
 .../assets/scss/super_admin/index.scss        | 29 ++++++++++---------
 .../installation/onboarding/index.html.erb    |  6 ++--
 2 files changed, 19 insertions(+), 16 deletions(-)

diff --git a/app/javascript/dashboard/assets/scss/super_admin/index.scss b/app/javascript/dashboard/assets/scss/super_admin/index.scss
index 205a10f70..f95f1303f 100644
--- a/app/javascript/dashboard/assets/scss/super_admin/index.scss
+++ b/app/javascript/dashboard/assets/scss/super_admin/index.scss
@@ -8,6 +8,22 @@
     font-weight: var(--font-weight-light);
     margin-top: var(--space-large);
   }
+
+  .update-subscription--checkbox {
+    display: flex;
+
+    input {
+      line-height: 1.5;
+      margin-right: var(--space-one);
+      margin-top: var(--space-smaller);
+    }
+
+    label {
+      font-size: var(--font-size-small);
+      line-height: 1.5;
+      margin-bottom: var(--space-normal);
+    }
+  }
 }
 
 .alert-box {
@@ -20,17 +36,4 @@
   text-align: center;
 }
 
-.update-subscription--checkbox {
-  display: flex;
 
-  input {
-    line-height: 1.5;
-    margin-right: var(--space-one);
-  }
-
-  div {
-    font-size: var(--font-size-small);
-    line-height: 1.5;
-    margin-bottom: var(--space-normal);
-  }
-}
diff --git a/app/views/installation/onboarding/index.html.erb b/app/views/installation/onboarding/index.html.erb
index 8287714cd..b58a4ee41 100644
--- a/app/views/installation/onboarding/index.html.erb
+++ b/app/views/installation/onboarding/index.html.erb
@@ -43,9 +43,9 @@
                 </label>
                 <div class="update-subscription--checkbox">
                   <%= check_box_tag "subscribe_to_updates", 'true', true %>
-                  <div for="subscribe_to_updates">
-                  Subscribe to release notes, newsletters & product feedback surveys.
-                  </div>
+                  <label for="subscribe_to_updates">
+                    Subscribe to release notes, newsletters & product feedback surveys.
+                  </label>
                 </div>
                 <button type="submit" class="button nice large expanded">
                   Finish Setup