chore: apply rubocop
This commit is contained in:
parent
af4ca9d974
commit
413078af19
@ -26,7 +26,7 @@ class Internal::Accounts::InternalAttributesService
|
|||||||
|
|
||||||
# Update the account
|
# Update the account
|
||||||
account.internal_attributes = new_attrs
|
account.internal_attributes = new_attrs
|
||||||
account.save
|
account.save!
|
||||||
end
|
end
|
||||||
|
|
||||||
# Get manually managed features
|
# Get manually managed features
|
||||||
|
|||||||
@ -42,7 +42,7 @@ RSpec.describe Internal::Accounts::InternalAttributesService do
|
|||||||
end
|
end
|
||||||
|
|
||||||
it 'creates internal_attributes hash if it is empty' do
|
it 'creates internal_attributes hash if it is empty' do
|
||||||
account.update(internal_attributes: {})
|
account.update!(internal_attributes: {})
|
||||||
|
|
||||||
# Stub the validation to allow our test key
|
# Stub the validation to allow our test key
|
||||||
allow(service).to receive(:validate_key!).and_return(true)
|
allow(service).to receive(:validate_key!).and_return(true)
|
||||||
@ -60,7 +60,7 @@ RSpec.describe Internal::Accounts::InternalAttributesService do
|
|||||||
end
|
end
|
||||||
|
|
||||||
it 'returns the features when they are set' do
|
it 'returns the features when they are set' do
|
||||||
account.update(internal_attributes: { 'manually_managed_features' => %w[feature1 feature2] })
|
account.update!(internal_attributes: { 'manually_managed_features' => %w[feature1 feature2] })
|
||||||
|
|
||||||
expect(service.manually_managed_features).to eq(%w[feature1 feature2])
|
expect(service.manually_managed_features).to eq(%w[feature1 feature2])
|
||||||
end
|
end
|
||||||
|
|||||||
@ -183,7 +183,7 @@ RSpec.describe Crm::Leadsquared::Mappers::ConversationMapper do
|
|||||||
expect(result.length).to be <= described_class::ACTIVITY_NOTE_MAX_SIZE + 100
|
expect(result.length).to be <= described_class::ACTIVITY_NOTE_MAX_SIZE + 100
|
||||||
|
|
||||||
# Verify that not all messages are included (some were truncated)
|
# Verify that not all messages are included (some were truncated)
|
||||||
expect(messages.count).to be > result.scan(/John Doe:/).count
|
expect(messages.count).to be > result.scan('John Doe:').count
|
||||||
end
|
end
|
||||||
|
|
||||||
it 'respects the ACTIVITY_NOTE_MAX_SIZE constant' do
|
it 'respects the ACTIVITY_NOTE_MAX_SIZE constant' do
|
||||||
|
|||||||
@ -51,7 +51,7 @@ RSpec.describe Crm::Leadsquared::ProcessorService do
|
|||||||
|
|
||||||
context 'when contact has no stored lead ID' do
|
context 'when contact has no stored lead ID' do
|
||||||
before do
|
before do
|
||||||
contact.update(additional_attributes: { 'external' => nil })
|
contact.update!(additional_attributes: { 'external' => nil })
|
||||||
contact.reload
|
contact.reload
|
||||||
|
|
||||||
allow(lead_client).to receive(:create_or_update_lead)
|
allow(lead_client).to receive(:create_or_update_lead)
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user