From 4935563b6064b29c1735336d751709a136a3851c Mon Sep 17 00:00:00 2001 From: gabrieljablonski Date: Wed, 9 Apr 2025 19:25:21 -0300 Subject: [PATCH] chore: apply rubocop --- app/builders/messages/instagram/base_message_builder.rb | 2 +- app/builders/messages/instagram/message_builder.rb | 2 +- app/builders/messages/instagram/messenger/message_builder.rb | 2 +- spec/builders/messages/instagram/message_builder_spec.rb | 4 ++-- spec/jobs/webhooks/instagram_events_job_spec.rb | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/builders/messages/instagram/base_message_builder.rb b/app/builders/messages/instagram/base_message_builder.rb index b8f892d97..7767ee1b4 100644 --- a/app/builders/messages/instagram/base_message_builder.rb +++ b/app/builders/messages/instagram/base_message_builder.rb @@ -161,7 +161,7 @@ class Messages::Instagram::BaseMessageBuilder < Messages::Messenger::MessageBuil end def all_unsupported_files? - return if attachments.empty? + return false if attachments.empty? attachments_type = attachments.pluck(:type).uniq.first unsupported_file_type?(attachments_type) diff --git a/app/builders/messages/instagram/message_builder.rb b/app/builders/messages/instagram/message_builder.rb index 4e7150894..e306c7b70 100644 --- a/app/builders/messages/instagram/message_builder.rb +++ b/app/builders/messages/instagram/message_builder.rb @@ -30,7 +30,7 @@ class Messages::Instagram::MessageBuilder < Messages::Instagram::BaseMessageBuil # https://developers.facebook.com/docs/graph-api/guides/error-handling/ search for error code 1609005 if error_code == 1_609_005 @message.attachments.destroy_all - @message.update(content: I18n.t('conversations.messages.instagram_deleted_story_content')) + @message.update!(content: I18n.t('conversations.messages.instagram_deleted_story_content')) end Rails.logger.error("[InstagramStoryFetchError]: #{parsed_response.dig('error', 'message')} #{error_code}") diff --git a/app/builders/messages/instagram/messenger/message_builder.rb b/app/builders/messages/instagram/messenger/message_builder.rb index 1263dee90..41ba59f2c 100644 --- a/app/builders/messages/instagram/messenger/message_builder.rb +++ b/app/builders/messages/instagram/messenger/message_builder.rb @@ -14,7 +14,7 @@ class Messages::Instagram::Messenger::MessageBuilder < Messages::Instagram::Base rescue Koala::Facebook::ClientError => e # The exception occurs when we are trying fetch the deleted story or blocked story. @message.attachments.destroy_all - @message.update(content: I18n.t('conversations.messages.instagram_deleted_story_content')) + @message.update!(content: I18n.t('conversations.messages.instagram_deleted_story_content')) Rails.logger.error e {} rescue StandardError => e diff --git a/spec/builders/messages/instagram/message_builder_spec.rb b/spec/builders/messages/instagram/message_builder_spec.rb index 0dbe87afa..4928e4d97 100644 --- a/spec/builders/messages/instagram/message_builder_spec.rb +++ b/spec/builders/messages/instagram/message_builder_spec.rb @@ -29,7 +29,7 @@ describe Messages::Instagram::MessageBuilder do describe '#perform' do before do - instagram_channel.update(access_token: 'valid_instagram_token') + instagram_channel.update!(access_token: 'valid_instagram_token') stub_request(:get, %r{https://graph\.instagram\.com/.*?/Sender-id-1\?.*}) .to_return( @@ -175,7 +175,7 @@ describe Messages::Instagram::MessageBuilder do end it 'handles authorization errors' do - instagram_channel.update(access_token: 'invalid_token') + instagram_channel.update!(access_token: 'invalid_token') # Stub the request to return authorization error status stub_request(:get, %r{https://graph\.instagram\.com/.*?/Sender-id-1\?.*}) diff --git a/spec/jobs/webhooks/instagram_events_job_spec.rb b/spec/jobs/webhooks/instagram_events_job_spec.rb index 23e7f9e5a..c3bcfadb2 100644 --- a/spec/jobs/webhooks/instagram_events_job_spec.rb +++ b/spec/jobs/webhooks/instagram_events_job_spec.rb @@ -182,7 +182,7 @@ describe Webhooks::InstagramEventsJob do context 'when handling messaging events for Instagram via Instagram login' do before do - instagram_channel.update(access_token: 'valid_instagram_token') + instagram_channel.update!(access_token: 'valid_instagram_token') stub_request(:get, %r{https://graph\.instagram\.com/v22\.0/Sender-id-1\?.*}) .to_return(