From 4d155e4c01ca8839bb51f6b7bb962fb999998a00 Mon Sep 17 00:00:00 2001
From: gabrieljablonski <contact@gabrieljablonski.com>
Date: Fri, 17 Apr 2026 16:40:00 -0300
Subject: [PATCH] fix(merge): CI offenses missed by pre-commit hook

- Editor.vue: consolidate duplicate defineExpose() calls introduced when
  removing signature functions (broke Vite build, cascaded into super_admin
  request specs via ActionView::Template::Error)
- omniauth_callbacks_controller + backfill migration: Rails/SaveBang
  autocorrect (offenses live in unchanged upstream files, so pre-commit
  hook skipped them; CI runs rubocop project-wide)
---
 .../devise_overrides/omniauth_callbacks_controller.rb         | 2 +-
 .../dashboard/components/widgets/WootWriter/Editor.vue        | 4 +---
 ...4636_backfill_feature_contact_attributes_for_assistants.rb | 4 ++--
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/app/controllers/devise_overrides/omniauth_callbacks_controller.rb b/app/controllers/devise_overrides/omniauth_callbacks_controller.rb
index 2c8387142..f0f6d5394 100644
--- a/app/controllers/devise_overrides/omniauth_callbacks_controller.rb
+++ b/app/controllers/devise_overrides/omniauth_callbacks_controller.rb
@@ -96,7 +96,7 @@ class DeviseOverrides::OmniauthCallbacksController < DeviseTokenAuth::OmniauthCa
 
   def set_random_password_if_oauth_user
     # Password must satisfy secure_password requirements (uppercase, lowercase, number, special char)
-    @resource.update(password: "#{SecureRandom.hex(16)}aA1!") if @resource.persisted?
+    @resource.update!(password: "#{SecureRandom.hex(16)}aA1!") if @resource.persisted?
   end
 
   def default_devise_mapping
diff --git a/app/javascript/dashboard/components/widgets/WootWriter/Editor.vue b/app/javascript/dashboard/components/widgets/WootWriter/Editor.vue
index dc1bfe30e..118266e01 100644
--- a/app/javascript/dashboard/components/widgets/WootWriter/Editor.vue
+++ b/app/javascript/dashboard/components/widgets/WootWriter/Editor.vue
@@ -843,8 +843,6 @@ onMounted(() => {
   }
 });
 
-defineExpose({ focusEditorInputField });
-
 // BUS Event to insert text or markdown into the editor at the
 // current cursor position.
 // Components using this
@@ -865,7 +863,7 @@ function insertMentionTrigger(char) {
   editorView.dispatch(tr);
 }
 
-defineExpose({ insertMentionTrigger });
+defineExpose({ focusEditorInputField, insertMentionTrigger });
 </script>
 
 <template>
diff --git a/db/migrate/20260320074636_backfill_feature_contact_attributes_for_assistants.rb b/db/migrate/20260320074636_backfill_feature_contact_attributes_for_assistants.rb
index 34ac1df5d..23337d867 100644
--- a/db/migrate/20260320074636_backfill_feature_contact_attributes_for_assistants.rb
+++ b/db/migrate/20260320074636_backfill_feature_contact_attributes_for_assistants.rb
@@ -8,7 +8,7 @@ class BackfillFeatureContactAttributesForAssistants < ActiveRecord::Migration[7.
       account.captain_assistants.each do |assistant|
         next if assistant.feature_contact_attributes.present?
 
-        assistant.update(feature_contact_attributes: true)
+        assistant.update!(feature_contact_attributes: true)
       end
     end
   end
@@ -20,7 +20,7 @@ class BackfillFeatureContactAttributesForAssistants < ActiveRecord::Migration[7.
       account.captain_assistants.each do |assistant|
         next if assistant.feature_contact_attributes.blank?
 
-        assistant.update(feature_contact_attributes: nil)
+        assistant.update!(feature_contact_attributes: nil)
       end
     end
   end