rodrigo/iachat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix: Catch audio context errors (#5051)

Browse Source 
Prevent errors in decoding and playing sounds from propagating
by catching them in the promise chain.

Fixes #4281.
This commit is contained in:
Chad Burggraf 2022-07-18 20:29:50 -07:00 committed by GitHub
parent 1dc7ce526e
commit 558e3c7499
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/javascript/shared/helpers/AudioNotificationHelper.js
View File

@ -16,7 +16,6 @@ export const getAlertAudio = async (baseUrl = '', type = 'dashboard') => {
}; };
}; };
try {
const resourceUrl = `${baseUrl}/audio/${type}/ding.mp3`; const resourceUrl = `${baseUrl}/audio/${type}/ding.mp3`;
const audioRequest = new Request(resourceUrl); const audioRequest = new Request(resourceUrl);
@ -25,10 +24,10 @@ export const getAlertAudio = async (baseUrl = '', type = 'dashboard') => {
.then(buffer => { .then(buffer => {
audioCtx.decodeAudioData(buffer).then(playsound); audioCtx.decodeAudioData(buffer).then(playsound);
return new Promise(res => res()); return new Promise(res => res());
}); })
} catch (error) { .catch(() => {
// error // error
} });
}; };
export const notificationEnabled = (enableAudioAlerts, id, userId) => { export const notificationEnabled = (enableAudioAlerts, id, userId) => {