rodrigo/iachat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix(captain/mcp): save_agent_spec — caminho de sucesso retorna tupla [hash, errors]

Browse Source 
Bug: expand_spec retornava [{}, errors] no erro mas só {hash} no sucesso.
Destruturação 'expanded, errors = expand_spec(...)' deixava errors=nil
→ errors.any? → undefined method any? for nil.

Fix: extraído build_expanded_hash + sucesso retorna [hash, []].

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Rodribm10 2026-05-02 13:26:25 -03:00
parent 828e2e6af3
commit 955cb824b3
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
enterprise/app/services/captain/mcp/tools/save_agent_spec_tool.rb
View File

@ -77,7 +77,7 @@ class Captain::Mcp::Tools::SaveAgentSpecTool < Captain::Mcp::Tools::BaseTool
private private
# rubocop:disable Metrics/MethodLength, Metrics/AbcSize # rubocop:disable Metrics/AbcSize
def expand_spec(slug, spec) def expand_spec(slug, spec)
errors = [] errors = []
parent_id = spec.dig('persona_source', 'copied_from_assistant_id') || parent_id = spec.dig('persona_source', 'copied_from_assistant_id') ||
@ -101,6 +101,12 @@ class Captain::Mcp::Tools::SaveAgentSpecTool < Captain::Mcp::Tools::BaseTool
name = spec['name'].presence || slug.tr('_', ' ').split.map(&:capitalize).join(' ') name = spec['name'].presence || slug.tr('_', ' ').split.map(&:capitalize).join(' ')
serialized_categories = pricing_categories.map { |c| serialize_category(c) } serialized_categories = pricing_categories.map { |c| serialize_category(c) }
[build_expanded_hash(slug, name, parent, parent_id, parent_unit, brand, spec, serialized_categories), errors]
end
# rubocop:enable Metrics/AbcSize
# rubocop:disable Metrics/ParameterLists
def build_expanded_hash(slug, name, parent, parent_id, parent_unit, brand, spec, serialized_categories)
{ {
'slug' => slug, 'slug' => slug,
'name' => name, 'name' => name,
@ -119,7 +125,7 @@ class Captain::Mcp::Tools::SaveAgentSpecTool < Captain::Mcp::Tools::BaseTool
'saved_by_tool' => 'mcp_save_agent_spec' 'saved_by_tool' => 'mcp_save_agent_spec'
} }
end end
# rubocop:enable Metrics/MethodLength, Metrics/AbcSize # rubocop:enable Metrics/ParameterLists
def lookup_brand(parent, brand_name) def lookup_brand(parent, brand_name)
return nil if parent.nil? return nil if parent.nil?