rodrigo/iachat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

chore: Remove message touch:true, use combined update query (#13770)

Browse Source 
Removes touch: true from the belongs_to :conversation association on
Message and consolidates the conversation timestamp update into the
existing set_conversation_activity callback.

Previously, every message save triggered two separate UPDATE queries on
the conversation — one from Rails' touch (updating updated_at) and
another from set_conversation_activity (updating last_activity_at). This
combines both into a single update_columns call, reducing write load on
the conversations table on every message creation.

### What changed
- Removed touch: true from belongs_to :conversation in Message
- Added updated_at: created_at to the existing update_columns call in
set_conversation_activity
This commit is contained in:
Pranav 2026-03-11 07:31:46 -07:00 committed by GitHub
parent 9b3f0029a4
commit c6f82783ba
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/message.rb
View File

@ -125,7 +125,7 @@ class Message < ApplicationRecord
belongs_to :account belongs_to :account
belongs_to :inbox belongs_to :inbox
belongs_to :conversation, touch: true belongs_to :conversation
belongs_to :sender, polymorphic: true, optional: true belongs_to :sender, polymorphic: true, optional: true
has_many :attachments, dependent: :destroy, autosave: true, before_add: :validate_attachments_limit has_many :attachments, dependent: :destroy, autosave: true, before_add: :validate_attachments_limit
@ -429,7 +429,7 @@ class Message < ApplicationRecord
def set_conversation_activity def set_conversation_activity
# rubocop:disable Rails/SkipsModelValidations # rubocop:disable Rails/SkipsModelValidations
conversation.update_columns(last_activity_at: created_at) conversation.update_columns(last_activity_at: created_at, updated_at: Time.current)
# rubocop:enable Rails/SkipsModelValidations # rubocop:enable Rails/SkipsModelValidations
end end