rodrigo/iachat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix: Cannot read properties of undefined (reading 'some') (#7278)

Browse Source 
Fixes https://linear.app/chatwoot/issue/CW-2041/typeerror-cannot-read-properties-of-undefined-reading-some
Fixes https://linear.app/chatwoot/issue/CW-2042/typeerror-cannot-read-properties-of-undefined-reading-filter
This commit is contained in:
Pranav Raj S 2023-06-08 20:12:14 -07:00 committed by GitHub
parent 7fd220c177
commit c8fac08e0b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/javascript/dashboard/store/modules/conversations/index.js
View File

@ -58,11 +58,10 @@ export const mutations = {
} }
}, },
[types.SET_ALL_ATTACHMENTS](_state, { id, data }) { [types.SET_ALL_ATTACHMENTS](_state, { id, data }) {
if (data.length) { const [chat] = _state.allConversations.filter(c => c.id === id);
const [chat] = _state.allConversations.filter(c => c.id === id); if (!chat) return;
Vue.set(chat, 'attachments', []); Vue.set(chat, 'attachments', []);
chat.attachments.push(...data); chat.attachments.push(...data);
}
}, },
[types.SET_MISSING_MESSAGES](_state, { id, data }) { [types.SET_MISSING_MESSAGES](_state, { id, data }) {
const [chat] = _state.allConversations.filter(c => c.id === id); const [chat] = _state.allConversations.filter(c => c.id === id);

8
app/javascript/dashboard/store/modules/specs/conversations/mutations.spec.js
View File

@ -288,6 +288,14 @@ describe('#mutations', () => {
mutations[types.SET_ALL_ATTACHMENTS](state, { id: 1, data }); mutations[types.SET_ALL_ATTACHMENTS](state, { id: 1, data });
expect(state.allConversations[0].attachments).toEqual(data); expect(state.allConversations[0].attachments).toEqual(data);
}); });
it('set attachments key even if the attachments are empty', () => {
const state = {
allConversations: [{ id: 1 }],
};
const data = [];
mutations[types.SET_ALL_ATTACHMENTS](state, { id: 1, data });
expect(state.allConversations[0].attachments).toEqual([]);
});
}); });
describe('#ADD_CONVERSATION_ATTACHMENTS', () => { describe('#ADD_CONVERSATION_ATTACHMENTS', () => {