c9b1917886
Upstream migration 20260324102005_repurpose_response_bot_flag_for_custom_tools calls InstallationConfig.value before the normalization migration (20260418020000) runs. On instances whose serialized_value column holds native jsonb hashes, that read raises "TypeError: no implicit conversion of Hash into String" and aborts the whole migration chain, leaving db:migrate stuck and production unable to deploy. Restore SerializedValueCoder.load that tolerates either shape. dump is updated to always emit YAML strings so new writes converge on the upstream format; the 20260418020000 migration still normalizes the backlog.
84 lines
2.4 KiB
Ruby
84 lines
2.4 KiB
Ruby
# == Schema Information
|
|
#
|
|
# Table name: installation_configs
|
|
#
|
|
# id :bigint not null, primary key
|
|
# locked :boolean default(TRUE), not null
|
|
# name :string not null
|
|
# serialized_value :jsonb not null
|
|
# created_at :datetime not null
|
|
# updated_at :datetime not null
|
|
#
|
|
# Indexes
|
|
#
|
|
# index_installation_configs_on_name (name) UNIQUE
|
|
# index_installation_configs_on_name_and_created_at (name,created_at) UNIQUE
|
|
#
|
|
class InstallationConfig < ApplicationRecord
|
|
# The serialized_value column is jsonb but production data is mixed: older rows
|
|
# were written as YAML strings by upstream's serialize :coder => YAML chain,
|
|
# and some rows were written as native jsonb hashes. The stock YAML coder
|
|
# raises TypeError on native-hash rows. This coder reads either shape and
|
|
# always writes YAML strings so data converges on a single format over time.
|
|
class SerializedValueCoder # rubocop:disable Style/OneClassPerFile
|
|
def self.dump(value)
|
|
hash = value.is_a?(Hash) ? value : { value: value }
|
|
YAML.dump(hash.with_indifferent_access)
|
|
end
|
|
|
|
def self.load(value)
|
|
return {}.with_indifferent_access if value.blank?
|
|
|
|
case value
|
|
when String
|
|
YAML.safe_load(value, permitted_classes: [ActiveSupport::HashWithIndifferentAccess, Symbol])
|
|
.with_indifferent_access
|
|
when Hash
|
|
value.with_indifferent_access
|
|
else
|
|
{}.with_indifferent_access
|
|
end
|
|
end
|
|
end
|
|
|
|
serialize :serialized_value, coder: SerializedValueCoder
|
|
|
|
before_validation :set_lock
|
|
validates :name, presence: true
|
|
validate :saml_sso_users_check, if: -> { name == 'ENABLE_SAML_SSO_LOGIN' }
|
|
|
|
# TODO: Get rid of default scope
|
|
# https://stackoverflow.com/a/1834250/939299
|
|
default_scope { order(created_at: :desc) }
|
|
scope :editable, -> { where(locked: false) }
|
|
|
|
after_commit :clear_cache
|
|
|
|
def value
|
|
serialized_value[:value]
|
|
end
|
|
|
|
def value=(value_to_assigned)
|
|
self.serialized_value = {
|
|
value: value_to_assigned
|
|
}.with_indifferent_access
|
|
end
|
|
|
|
private
|
|
|
|
def set_lock
|
|
self.locked = true if locked.nil?
|
|
end
|
|
|
|
def clear_cache
|
|
GlobalConfig.clear_cache
|
|
end
|
|
|
|
def saml_sso_users_check
|
|
return unless value == false || value == 'false'
|
|
return unless User.exists?(provider: 'saml')
|
|
|
|
errors.add(:base, 'Cannot disable SAML SSO login while users are using SAML authentication')
|
|
end
|
|
end
|