Resolves 26 conflicts via manual review. Key decisions: - signature: kept fork's send-time architecture (PR #79), discarded upstream's editor-manipulation functions - WhatsApp incoming: combined fork's two-layer locking (source_id + contact phone) with upstream's blocked-contact drop. Fixed pre-existing regression where echoes were silently dropped - InstallationConfig: upstream's simplified coder (validated against legacy YAML-in-jsonb data) - schema.rb: regenerated, stripped kanban tables from other branches, restored f_unaccent SQL function
183 lines
6.8 KiB
Ruby
183 lines
6.8 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe ActionService do
|
|
let(:account) { create(:account) }
|
|
|
|
describe '#resolve_conversation' do
|
|
let(:conversation) { create(:conversation) }
|
|
let(:action_service) { described_class.new(conversation) }
|
|
|
|
it 'resolves the conversation' do
|
|
expect(conversation.status).to eq('open')
|
|
action_service.resolve_conversation(nil)
|
|
expect(conversation.reload.status).to eq('resolved')
|
|
end
|
|
end
|
|
|
|
describe '#open_conversation' do
|
|
let(:conversation) { create(:conversation, status: :resolved) }
|
|
let(:action_service) { described_class.new(conversation) }
|
|
|
|
it 'opens the conversation' do
|
|
expect(conversation.status).to eq('resolved')
|
|
action_service.open_conversation(nil)
|
|
expect(conversation.reload.status).to eq('open')
|
|
end
|
|
end
|
|
|
|
describe '#change_priority' do
|
|
let(:conversation) { create(:conversation) }
|
|
let(:action_service) { described_class.new(conversation) }
|
|
|
|
it 'changes the priority of the conversation to medium' do
|
|
action_service.change_priority(['medium'])
|
|
expect(conversation.reload.priority).to eq('medium')
|
|
end
|
|
|
|
it 'changes the priority of the conversation to nil' do
|
|
action_service.change_priority(['nil'])
|
|
expect(conversation.reload.priority).to be_nil
|
|
end
|
|
end
|
|
|
|
describe '#assign_agent' do
|
|
let(:agent) { create(:user, account: account, role: :agent) }
|
|
let(:inbox_member) { create(:inbox_member, inbox: conversation.inbox, user: agent) }
|
|
let(:conversation) { create(:conversation, :with_assignee, account: account) }
|
|
let(:action_service) { described_class.new(conversation) }
|
|
|
|
it 'unassigns the conversation if agent id is nil' do
|
|
action_service.assign_agent(['nil'])
|
|
expect(conversation.reload.assignee).to be_nil
|
|
end
|
|
|
|
context 'when agent is confirmed' do
|
|
it 'assigns the agent to the conversation' do
|
|
inbox_member
|
|
action_service.assign_agent([agent.id])
|
|
expect(conversation.reload.assignee).to eq(agent)
|
|
end
|
|
end
|
|
|
|
context 'when agent is unconfirmed' do
|
|
let(:unconfirmed_agent) { create(:user, account: account, role: :agent, skip_confirmation: false) }
|
|
let(:unconfirmed_inbox_member) { create(:inbox_member, inbox: conversation.inbox, user: unconfirmed_agent) }
|
|
|
|
it 'does not assign unconfirmed agent to the conversation' do
|
|
unconfirmed_inbox_member
|
|
original_assignee = conversation.assignee
|
|
action_service.assign_agent([unconfirmed_agent.id])
|
|
expect(conversation.reload.assignee).to eq(original_assignee)
|
|
end
|
|
end
|
|
|
|
context 'when assigning the last responding agent' do
|
|
it 'assigns the last agent who replied publicly' do
|
|
note_author = create(:user, account: account, role: :agent)
|
|
inbox_member
|
|
create(:inbox_member, inbox: conversation.inbox, user: note_author)
|
|
create(:message, message_type: :outgoing, account: account,
|
|
inbox: conversation.inbox, conversation: conversation, sender: agent)
|
|
create(:message, message_type: :outgoing, private: true, account: account,
|
|
inbox: conversation.inbox, conversation: conversation, sender: note_author)
|
|
|
|
action_service.assign_agent(['last_responding_agent'])
|
|
|
|
expect(conversation.reload.assignee).to eq(agent)
|
|
end
|
|
|
|
it 'does not assign the conversation when there is no public agent reply' do
|
|
inbox_member
|
|
original_assignee = conversation.assignee
|
|
create(:message, message_type: :outgoing, private: true, account: account,
|
|
inbox: conversation.inbox, conversation: conversation, sender: agent)
|
|
|
|
action_service.assign_agent(['last_responding_agent'])
|
|
|
|
expect(conversation.reload.assignee).to eq(original_assignee)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#assign_team' do
|
|
let(:agent) { create(:user, account: account, role: :agent) }
|
|
let(:inbox_member) { create(:inbox_member, inbox: conversation.inbox, user: agent) }
|
|
let(:team) { create(:team, name: 'ConversationTeam', account: account) }
|
|
let(:conversation) { create(:conversation, :with_team, account: account) }
|
|
let(:action_service) { described_class.new(conversation) }
|
|
|
|
context 'when team_id is not present' do
|
|
it 'unassign the if team_id is "nil"' do
|
|
expect do
|
|
action_service.assign_team(['nil'])
|
|
end.not_to raise_error
|
|
expect(conversation.reload.team).to be_nil
|
|
end
|
|
|
|
it 'unassign the if team_id is 0' do
|
|
expect do
|
|
action_service.assign_team([0])
|
|
end.not_to raise_error
|
|
expect(conversation.reload.team).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'when team_id is present' do
|
|
it 'assign the team if the team is part of the account' do
|
|
original_team = conversation.team
|
|
expect do
|
|
action_service.assign_team([team.id])
|
|
end.to change { conversation.reload.team }.from(original_team)
|
|
end
|
|
|
|
it 'does not assign the team if the team is part of the account' do
|
|
original_team = conversation.team
|
|
invalid_team_id = 999_999_999
|
|
expect do
|
|
action_service.assign_team([invalid_team_id])
|
|
end.not_to change { conversation.reload.team }.from(original_team)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#remove_assigned_agent' do
|
|
let(:conversation) { create(:conversation, :with_assignee, account: account) }
|
|
let(:action_service) { described_class.new(conversation) }
|
|
|
|
it 'unassigns the conversation' do
|
|
expect(conversation.reload.assignee).to be_present
|
|
action_service.remove_assigned_agent(nil)
|
|
expect(conversation.reload.assignee).to be_nil
|
|
end
|
|
end
|
|
|
|
describe '#create_scheduled_message' do
|
|
it 'creates scheduled message with content and delay' do
|
|
conversation = create(:conversation, account: account)
|
|
user = create(:user, account: account)
|
|
Current.user = user
|
|
action_service = described_class.new(conversation)
|
|
|
|
action_service.create_scheduled_message([{ content: 'Hello', delay_minutes: 10 }])
|
|
|
|
scheduled_message = conversation.scheduled_messages.last
|
|
|
|
expect(scheduled_message.content).to eq('Hello')
|
|
expect(scheduled_message.status).to eq('pending')
|
|
expect(scheduled_message.scheduled_at).to be_within(1.minute).of(10.minutes.from_now)
|
|
end
|
|
|
|
it 'attaches blob when blob_id is provided' do
|
|
conversation = create(:conversation, account: account)
|
|
user = create(:user, account: account)
|
|
Current.user = user
|
|
action_service = described_class.new(conversation)
|
|
blob = ActiveStorage::Blob.create_and_upload!(io: Rails.root.join('spec/assets/avatar.png').open, filename: 'avatar.png')
|
|
|
|
action_service.create_scheduled_message([{ content: 'With attachment', delay_minutes: 5, blob_id: blob.id }])
|
|
|
|
expect(conversation.scheduled_messages.last.attachment).to be_attached
|
|
end
|
|
end
|
|
end
|