* chore: exclude inbox_id from webhook update parameters * feat: display inbox label in webhook settings * feat: add inbox selection to webhook form * feat: prevent updating inbox_id in webhook update * feat: integrate MultiselectDropdown for inbox selection in webhook form * feat: add inbox matching logic to webhook event delivery * feat: remove unused inbox input placeholder from webhook form * fix: MultiselectDropdown component submiting form * feat: refine webhook parameters for create and update actions * feat: disable URL input field when editing webhook * chore: remove unnecessary parentheses * chore: update webhook controller spec to ignore inbox_id and url updates * fix: clean up JSON formatting * fix: standardize inbox_id to inboxId in WebhookForm component * refactor: replace LabelItem with InboxName component in WebhookRow * chore: enhance MultiselectDropdown with button variant prop and update styling in WebhookForm * chore: simplify MultiselectDropdown wrapper in WebhookForm component * chore: update selectedInbox initialization to null and reorder form fields * refactor: simplify InboxName * chore: add dark variant styling for buttons in SCSS * test: add inbox filtering for webhook event triggers in WebhookListener * test: refactor webhook controller spec to use a variable for URL and improve update expectations * feat(webhook): all inboxes option * chore: remove dark variant styling for buttons in SCSS * fix: bad interaction multiselectdropdown inside label * chore: invert if * chore: rename to assignedInbox and drop inboxId * refactor(WebhookForm): restore div separating fields from buttons * test: improve description --------- Co-authored-by: gabrieljablonski <contact@gabrieljablonski.com>
159 lines
6.4 KiB
Ruby
159 lines
6.4 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe 'Webhooks API', type: :request do
|
|
let(:url) { 'https://hello.com' }
|
|
let(:account) { create(:account) }
|
|
let(:inbox) { create(:inbox, account: account) }
|
|
let(:webhook) { create(:webhook, account: account, inbox: inbox, url: url, name: 'My Webhook') }
|
|
let(:administrator) { create(:user, account: account, role: :administrator) }
|
|
let(:agent) { create(:user, account: account, role: :agent) }
|
|
|
|
describe 'GET /api/v1/accounts/<account_id>/webhooks' do
|
|
context 'when it is an authenticated agent' do
|
|
it 'returns unauthorized' do
|
|
get "/api/v1/accounts/#{account.id}/webhooks",
|
|
headers: agent.create_new_auth_token,
|
|
as: :json
|
|
expect(response).to have_http_status(:unauthorized)
|
|
end
|
|
end
|
|
|
|
context 'when it is an authenticated admin user' do
|
|
it 'gets all webhook' do
|
|
get "/api/v1/accounts/#{account.id}/webhooks",
|
|
headers: administrator.create_new_auth_token,
|
|
as: :json
|
|
expect(response).to have_http_status(:success)
|
|
expect(response.parsed_body['payload']['webhooks'].count).to eql account.webhooks.count
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'POST /api/v1/accounts/<account_id>/webhooks' do
|
|
context 'when it is an authenticated agent' do
|
|
it 'returns unauthorized' do
|
|
post "/api/v1/accounts/#{account.id}/webhooks",
|
|
headers: agent.create_new_auth_token,
|
|
as: :json
|
|
expect(response).to have_http_status(:unauthorized)
|
|
end
|
|
end
|
|
|
|
context 'when it is an authenticated admin user' do
|
|
it 'creates webhook' do
|
|
post "/api/v1/accounts/#{account.id}/webhooks",
|
|
params: { account_id: account.id, inbox_id: inbox.id, url: 'https://hello.com' },
|
|
headers: administrator.create_new_auth_token,
|
|
as: :json
|
|
expect(response).to have_http_status(:success)
|
|
|
|
expect(response.parsed_body['payload']['webhook']['url']).to eql 'https://hello.com'
|
|
end
|
|
|
|
it 'creates webhook with name' do
|
|
post "/api/v1/accounts/#{account.id}/webhooks",
|
|
params: { account_id: account.id, inbox_id: inbox.id, url: 'https://hello.com', name: 'My Webhook' },
|
|
headers: administrator.create_new_auth_token,
|
|
as: :json
|
|
expect(response).to have_http_status(:success)
|
|
|
|
expect(response.parsed_body['payload']['webhook']['name']).to eql 'My Webhook'
|
|
end
|
|
|
|
it 'throws error when invalid url provided' do
|
|
post "/api/v1/accounts/#{account.id}/webhooks",
|
|
params: { account_id: account.id, inbox_id: inbox.id, url: 'javascript:alert(1)' },
|
|
headers: administrator.create_new_auth_token,
|
|
as: :json
|
|
expect(response).to have_http_status(:unprocessable_entity)
|
|
expect(response.parsed_body['message']).to eql 'Url is invalid'
|
|
end
|
|
|
|
it 'throws error if subscription events are invalid' do
|
|
post "/api/v1/accounts/#{account.id}/webhooks",
|
|
params: { url: 'https://hello.com', subscriptions: ['conversation_random_event'] },
|
|
headers: administrator.create_new_auth_token,
|
|
as: :json
|
|
expect(response).to have_http_status(:unprocessable_entity)
|
|
expect(response.parsed_body['message']).to eql 'Subscriptions Invalid events'
|
|
end
|
|
|
|
it 'throws error if subscription events are empty' do
|
|
post "/api/v1/accounts/#{account.id}/webhooks",
|
|
params: { url: 'https://hello.com', subscriptions: [] },
|
|
headers: administrator.create_new_auth_token,
|
|
as: :json
|
|
expect(response).to have_http_status(:unprocessable_entity)
|
|
expect(response.parsed_body['message']).to eql 'Subscriptions Invalid events'
|
|
end
|
|
|
|
it 'use default if subscription events are nil' do
|
|
post "/api/v1/accounts/#{account.id}/webhooks",
|
|
params: { url: 'https://hello.com', subscriptions: nil },
|
|
headers: administrator.create_new_auth_token,
|
|
as: :json
|
|
expect(response).to have_http_status(:ok)
|
|
expect(
|
|
response.parsed_body['payload']['webhook']['subscriptions']
|
|
).to eql %w[conversation_status_changed conversation_updated conversation_created contact_created contact_updated
|
|
message_created message_updated webwidget_triggered]
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'PUT /api/v1/accounts/<account_id>/webhooks/:id' do
|
|
context 'when it is an authenticated agent' do
|
|
it 'returns unauthorized' do
|
|
put "/api/v1/accounts/#{account.id}/webhooks/#{webhook.id}",
|
|
headers: agent.create_new_auth_token,
|
|
as: :json
|
|
expect(response).to have_http_status(:unauthorized)
|
|
end
|
|
end
|
|
|
|
context 'when it is an authenticated admin user' do
|
|
it 'updates webhook' do
|
|
put "/api/v1/accounts/#{account.id}/webhooks/#{webhook.id}",
|
|
params: { name: 'Another Webhook' },
|
|
headers: administrator.create_new_auth_token,
|
|
as: :json
|
|
expect(response).to have_http_status(:success)
|
|
expect(response.parsed_body['payload']['webhook']['name']).to eql 'Another Webhook'
|
|
end
|
|
|
|
it 'ignores trying to update inbox_id and url' do
|
|
new_inbox = create(:inbox, account: account)
|
|
|
|
put "/api/v1/accounts/#{account.id}/webhooks/#{webhook.id}",
|
|
params: { url: 'https://other.url.com', inbox_id: new_inbox.id },
|
|
headers: administrator.create_new_auth_token,
|
|
as: :json
|
|
expect(response).to have_http_status(:success)
|
|
expect(response.parsed_body['payload']['webhook']['url']).to eql url
|
|
expect(response.parsed_body['payload']['webhook']['inbox']['id']).to eql inbox.id
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'DELETE /api/v1/accounts/<account_id>/webhooks/:id' do
|
|
context 'when it is an authenticated agent' do
|
|
it 'returns unauthorized' do
|
|
delete "/api/v1/accounts/#{account.id}/webhooks/#{webhook.id}",
|
|
headers: agent.create_new_auth_token,
|
|
as: :json
|
|
expect(response).to have_http_status(:unauthorized)
|
|
end
|
|
end
|
|
|
|
context 'when it is an authenticated admin user' do
|
|
it 'deletes webhook' do
|
|
delete "/api/v1/accounts/#{account.id}/webhooks/#{webhook.id}",
|
|
headers: administrator.create_new_auth_token,
|
|
as: :json
|
|
expect(response).to have_http_status(:success)
|
|
expect(account.webhooks.count).to be 0
|
|
end
|
|
end
|
|
end
|
|
end
|