# Replace the deprecated `eventBus` with mitt.js ## Description Since eventBus and it's respective methods are deprecated and removed from all future releases of vue, this was blocking us from migrating. This PR replaces eventBus with [mitt](https://github.com/developit/mitt). I have created a wrapper mitt.js to simulate the same old event names so it's backwards compatible, without making a lot of changes. Fixes # (issue) ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? 1. Made sure all the places we're listening to bus events are working as expected. 2. Respective specsf or the events from mitt. ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules
177 lines
5.3 KiB
Vue
177 lines
5.3 KiB
Vue
<template>
|
|
<div
|
|
class="app-wrapper h-full flex-grow-0 min-h-0 w-full max-w-full ml-auto mr-auto flex flex-wrap dark:text-slate-300"
|
|
>
|
|
<sidebar
|
|
:route="currentRoute"
|
|
:show-secondary-sidebar="isSidebarOpen"
|
|
@open-notification-panel="openNotificationPanel"
|
|
@toggle-account-modal="toggleAccountModal"
|
|
@open-key-shortcut-modal="toggleKeyShortcutModal"
|
|
@close-key-shortcut-modal="closeKeyShortcutModal"
|
|
@show-add-label-popup="showAddLabelPopup"
|
|
/>
|
|
<section class="flex h-full min-h-0 overflow-hidden flex-1 px-0">
|
|
<router-view />
|
|
<command-bar />
|
|
<account-selector
|
|
:show-account-modal="showAccountModal"
|
|
@close-account-modal="toggleAccountModal"
|
|
@show-create-account-modal="openCreateAccountModal"
|
|
/>
|
|
<add-account-modal
|
|
:show="showCreateAccountModal"
|
|
@close-account-create-modal="closeCreateAccountModal"
|
|
/>
|
|
<woot-key-shortcut-modal
|
|
:show.sync="showShortcutModal"
|
|
@close="closeKeyShortcutModal"
|
|
@clickaway="closeKeyShortcutModal"
|
|
/>
|
|
<notification-panel
|
|
v-if="isNotificationPanel"
|
|
@close="closeNotificationPanel"
|
|
/>
|
|
<woot-modal :show.sync="showAddLabelModal" :on-close="hideAddLabelPopup">
|
|
<add-label-modal @close="hideAddLabelPopup" />
|
|
</woot-modal>
|
|
</section>
|
|
</div>
|
|
</template>
|
|
|
|
<script>
|
|
import Sidebar from '../../components/layout/Sidebar.vue';
|
|
import CommandBar from './commands/commandbar.vue';
|
|
import { BUS_EVENTS } from 'shared/constants/busEvents';
|
|
import WootKeyShortcutModal from 'dashboard/components/widgets/modal/WootKeyShortcutModal.vue';
|
|
import AddAccountModal from 'dashboard/components/layout/sidebarComponents/AddAccountModal.vue';
|
|
import AccountSelector from 'dashboard/components/layout/sidebarComponents/AccountSelector.vue';
|
|
import AddLabelModal from 'dashboard/routes/dashboard/settings/labels/AddLabel.vue';
|
|
import NotificationPanel from 'dashboard/routes/dashboard/notifications/components/NotificationPanel.vue';
|
|
import uiSettingsMixin from 'dashboard/mixins/uiSettings';
|
|
import wootConstants from 'dashboard/constants/globals';
|
|
|
|
export default {
|
|
components: {
|
|
Sidebar,
|
|
CommandBar,
|
|
WootKeyShortcutModal,
|
|
AddAccountModal,
|
|
AccountSelector,
|
|
AddLabelModal,
|
|
NotificationPanel,
|
|
},
|
|
mixins: [uiSettingsMixin],
|
|
data() {
|
|
return {
|
|
showAccountModal: false,
|
|
showCreateAccountModal: false,
|
|
showAddLabelModal: false,
|
|
showShortcutModal: false,
|
|
isNotificationPanel: false,
|
|
displayLayoutType: '',
|
|
};
|
|
},
|
|
computed: {
|
|
currentRoute() {
|
|
return ' ';
|
|
},
|
|
isSidebarOpen() {
|
|
const { show_secondary_sidebar: showSecondarySidebar } = this.uiSettings;
|
|
return showSecondarySidebar;
|
|
},
|
|
previouslyUsedDisplayType() {
|
|
const {
|
|
previously_used_conversation_display_type: conversationDisplayType,
|
|
} = this.uiSettings;
|
|
return conversationDisplayType;
|
|
},
|
|
previouslyUsedSidebarView() {
|
|
const { previously_used_sidebar_view: showSecondarySidebar } =
|
|
this.uiSettings;
|
|
return showSecondarySidebar;
|
|
},
|
|
},
|
|
watch: {
|
|
displayLayoutType() {
|
|
const { LAYOUT_TYPES } = wootConstants;
|
|
this.updateUISettings({
|
|
conversation_display_type:
|
|
this.displayLayoutType === LAYOUT_TYPES.EXPANDED
|
|
? LAYOUT_TYPES.EXPANDED
|
|
: this.previouslyUsedDisplayType,
|
|
show_secondary_sidebar:
|
|
this.displayLayoutType === LAYOUT_TYPES.EXPANDED
|
|
? false
|
|
: this.previouslyUsedSidebarView,
|
|
});
|
|
},
|
|
},
|
|
mounted() {
|
|
this.handleResize();
|
|
window.addEventListener('resize', this.handleResize);
|
|
this.$emitter.on(BUS_EVENTS.TOGGLE_SIDEMENU, this.toggleSidebar);
|
|
},
|
|
beforeDestroy() {
|
|
window.removeEventListener('resize', this.handleResize);
|
|
this.$emitter.off(BUS_EVENTS.TOGGLE_SIDEMENU, this.toggleSidebar);
|
|
},
|
|
|
|
methods: {
|
|
handleResize() {
|
|
const { SMALL_SCREEN_BREAKPOINT, LAYOUT_TYPES } = wootConstants;
|
|
let throttled = false;
|
|
const delay = 150;
|
|
|
|
if (throttled) {
|
|
return;
|
|
}
|
|
throttled = true;
|
|
|
|
setTimeout(() => {
|
|
throttled = false;
|
|
if (window.innerWidth <= SMALL_SCREEN_BREAKPOINT) {
|
|
this.displayLayoutType = LAYOUT_TYPES.EXPANDED;
|
|
} else {
|
|
this.displayLayoutType = LAYOUT_TYPES.CONDENSED;
|
|
}
|
|
}, delay);
|
|
},
|
|
toggleSidebar() {
|
|
this.updateUISettings({
|
|
show_secondary_sidebar: !this.isSidebarOpen,
|
|
previously_used_sidebar_view: !this.isSidebarOpen,
|
|
});
|
|
},
|
|
openCreateAccountModal() {
|
|
this.showAccountModal = false;
|
|
this.showCreateAccountModal = true;
|
|
},
|
|
closeCreateAccountModal() {
|
|
this.showCreateAccountModal = false;
|
|
},
|
|
toggleAccountModal() {
|
|
this.showAccountModal = !this.showAccountModal;
|
|
},
|
|
toggleKeyShortcutModal() {
|
|
this.showShortcutModal = true;
|
|
},
|
|
closeKeyShortcutModal() {
|
|
this.showShortcutModal = false;
|
|
},
|
|
showAddLabelPopup() {
|
|
this.showAddLabelModal = true;
|
|
},
|
|
hideAddLabelPopup() {
|
|
this.showAddLabelModal = false;
|
|
},
|
|
openNotificationPanel() {
|
|
this.isNotificationPanel = true;
|
|
},
|
|
closeNotificationPanel() {
|
|
this.isNotificationPanel = false;
|
|
},
|
|
},
|
|
};
|
|
</script>
|