d6d38cdd7d
# Pull Request Template ## Description captain decides if conversation should be resolved or open Fixes https://linear.app/chatwoot/issue/AI-91/make-captain-resolution-time-configurable Update: Added 2 entries in reporting events: `conversation_captain_handoff` and `conversation_captain_resolved` ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) - [x] This change requires a documentation update ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. LLM call decides that conversation is resolved, drops a private note <img width="1228" height="438" alt="image" src="https://github.com/user-attachments/assets/fb2cf1e9-4b2b-458b-a1e2-45c53d6a0158" /> LLM call decides conversation is still open as query was not resolved <img width="1215" height="573" alt="image" src="https://github.com/user-attachments/assets/2d1d5322-f567-487e-954e-11ab0798d11c" /> ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Sojan Jose <sojan@pepalo.com>
68 lines
2.3 KiB
Ruby
68 lines
2.3 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Captain::Tools::ResolveConversationTool do
|
|
let(:account) { create(:account) }
|
|
let(:assistant) { create(:captain_assistant, account: account) }
|
|
let(:inbox) { create(:inbox, account: account) }
|
|
let(:conversation) { create(:conversation, account: account, inbox: inbox, status: :open) }
|
|
let(:tool) { described_class.new(assistant) }
|
|
let(:tool_context) { Struct.new(:state).new({ conversation: { id: conversation.id } }) }
|
|
|
|
before do
|
|
Current.executed_by = assistant
|
|
end
|
|
|
|
after do
|
|
Current.reset
|
|
end
|
|
|
|
describe 'resolving a conversation' do
|
|
it 'marks resolved and enqueues an activity message with the reason' do
|
|
tool.perform(tool_context, reason: 'Possible spam')
|
|
|
|
expect(conversation.reload).to be_resolved
|
|
expect(Conversations::ActivityMessageJob).to have_been_enqueued.with(
|
|
conversation,
|
|
hash_including(
|
|
content: I18n.t('conversations.activity.captain.resolved_by_tool', user_name: assistant.name, reason: 'Possible spam')
|
|
)
|
|
)
|
|
end
|
|
|
|
it 'creates a conversation_resolved reporting event' do
|
|
create(:captain_inbox, captain_assistant: assistant, inbox: inbox)
|
|
|
|
expect do
|
|
perform_enqueued_jobs do
|
|
tool.perform(tool_context, reason: 'Possible spam')
|
|
end
|
|
end.to change { ReportingEvent.where(conversation_id: conversation.id, name: 'conversation_resolved').count }.by(1)
|
|
end
|
|
end
|
|
|
|
describe 'when auto-resolve is disabled for the account' do
|
|
before { account.update!(captain_disable_auto_resolve: true) }
|
|
|
|
it 'does not resolve and returns a disabled message' do
|
|
result = tool.perform(tool_context, reason: 'Possible spam')
|
|
|
|
expect(result).to eq('Auto-resolve is disabled for this account')
|
|
expect(conversation.reload).not_to be_resolved
|
|
end
|
|
end
|
|
|
|
describe 'resolving an already resolved conversation' do
|
|
let(:conversation) { create(:conversation, account: account, inbox: inbox, status: :resolved) }
|
|
|
|
it 'does not re-resolve and returns an already resolved message' do
|
|
queue_adapter = ActiveJob::Base.queue_adapter
|
|
queue_adapter.enqueued_jobs.clear
|
|
|
|
result = tool.perform(tool_context, reason: 'Possible spam')
|
|
|
|
expect(result).to include('already resolved')
|
|
expect(Conversations::ActivityMessageJob).not_to have_been_enqueued
|
|
end
|
|
end
|
|
end
|