iachat/app
Daniel Jimenez 918f8e6f8e
fix: AgentTable report showing test value for zero conversations (#10641)
# Pull Request Template

## Description

Changed to make use of nullish coalescing operator to only short circuit
in cases when the `metric` variable is not zero. This change also begs
the question as to whether the `stringToFloat` test function should
exist - to me it seems interesting to have test code embedded into
production code for the frontend?
Fixes #10640

## Type of change

Please delete options that are not relevant.

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality not to work as expected)
- [ ] This change requires a documentation update

## How Has This Been Tested?

Tested by opening the report overview page and reviewing that this shows
`---` for agents with no conversations assigned to them.


## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my code
- [x] I have commented on my code, particularly in hard-to-understand
areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [x] Any dependent changes have been merged and published in downstream
modules

---------

Co-authored-by: Shivam Mishra <scm.mymail@gmail.com>
2025-01-06 13:51:27 +05:30
..
actions chore: Avoid contact inboxes getting deleted (#10612) 2024-12-26 16:17:38 +05:30
assets feat: Vite + vue 3 💚 (#10047) 2024-10-02 00:36:30 -07:00
builders feat(v4): Update team, agent summary builder to include resolution metrics (#10607) 2024-12-20 19:16:56 +05:30
channels chore: Sentry issues (#4623) 2022-05-06 14:50:55 +05:30
controllers feat(v4): Add API to fetch aggregate reports for inboxes (#10604) 2024-12-19 14:47:19 -08:00
dashboards feat: Display Account Custom Attributes in Super Admin (#10459) 2024-11-20 09:02:33 -08:00
dispatchers fix: assignee_changed callback not getting triggered during conversation creation (#9334) 2024-05-06 11:48:17 -07:00
drops feat: Add the support for custom attributes in message variables (#8511) 2023-12-08 14:13:35 -08:00
fields feat: Supports masking tokens in super admin (#6491) 2023-02-21 17:50:55 +05:30
finders feat: Conversation API to return applied_sla and sla_events (#9174) 2024-04-01 23:30:07 +05:30
helpers feat: validate query conditions (#10595) 2024-12-17 17:16:37 +05:30
javascript fix: AgentTable report showing test value for zero conversations (#10641) 2025-01-06 13:51:27 +05:30
jobs fix: RemoveStaleRedisKeys service (#10562) 2024-12-11 03:38:25 +08:00
listeners fix: Use message sender ID in the analytics for first response time (#9605) 2024-06-06 20:20:35 -07:00
mailboxes chore: Disable throwing error for malformed to address (#10464) 2024-11-20 18:58:54 -08:00
mailers feat: add Google Email fetch and OAuth token refresh service (#9603) 2024-06-11 14:22:03 +05:30
models feat: validate query conditions (#10595) 2024-12-17 17:16:37 +05:30
policies chore: Custom Roles to manage permissions [ UI ] (#9865) 2024-09-17 11:40:11 -07:00
presenters fix: Email attachments created with empty filename (#10420) 2024-11-15 09:07:24 +04:00
services feat: validate query conditions (#10595) 2024-12-17 17:16:37 +05:30
views fix: Remove duplicate contactable inbox in the conversation form (#10554) 2024-12-06 12:31:01 -08:00
workers fix: Capture delivery errors to avoid false positives (#8790) 2024-01-26 14:22:18 +04:00