Update BulkSelectBar to compute selection state (indeterminate/all) from visible item IDs and only toggle selection for visible items. Preserve existing selection for off-screen items when toggling, and guard against empty visibility. Add detection/rendering for an optional secondary-actions slot and adjust layout/divider. Also fix ContactsBulkActionBar selection logic to determine "all selected" by verifying every visible ID is in the selection. These changes ensure correct select-all behavior with filtered/visible lists and support additional UI actions. https://github.com/user-attachments/assets/d06b78d1-a64a-4c0c-a82a-f870140236c7 # Pull Request Template ## Description Please include a summary of the change and issue(s) fixed. Also, mention relevant motivation, context, and any dependencies that this change requires. Fixes # (issue) ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: iamsivin <iamsivin@gmail.com>
167 lines
4.7 KiB
Vue
167 lines
4.7 KiB
Vue
<script setup>
|
|
import { computed, ref } from 'vue';
|
|
import { useI18n } from 'vue-i18n';
|
|
import { vOnClickOutside } from '@vueuse/components';
|
|
|
|
import BulkSelectBar from 'dashboard/components-next/captain/assistant/BulkSelectBar.vue';
|
|
import Button from 'dashboard/components-next/button/Button.vue';
|
|
import LabelActions from 'dashboard/components/widgets/conversation/conversationBulkActions/LabelActions.vue';
|
|
import Policy from 'dashboard/components/policy.vue';
|
|
|
|
const props = defineProps({
|
|
visibleContactIds: {
|
|
type: Array,
|
|
default: () => [],
|
|
},
|
|
selectedContactIds: {
|
|
type: Array,
|
|
default: () => [],
|
|
},
|
|
isLoading: {
|
|
type: Boolean,
|
|
default: false,
|
|
},
|
|
});
|
|
|
|
const emit = defineEmits([
|
|
'clearSelection',
|
|
'assignLabels',
|
|
'toggleAll',
|
|
'deleteSelected',
|
|
]);
|
|
|
|
const { t } = useI18n();
|
|
|
|
const selectedCount = computed(() => props.selectedContactIds.length);
|
|
const totalVisibleContacts = computed(() => props.visibleContactIds.length);
|
|
const showLabelSelector = ref(false);
|
|
|
|
const selectAllLabel = computed(() => {
|
|
if (!totalVisibleContacts.value) {
|
|
return '';
|
|
}
|
|
|
|
return t('CONTACTS_BULK_ACTIONS.SELECT_ALL', {
|
|
count: totalVisibleContacts.value,
|
|
});
|
|
});
|
|
|
|
const selectedCountLabel = computed(() =>
|
|
t('CONTACTS_BULK_ACTIONS.SELECTED_COUNT', {
|
|
count: selectedCount.value,
|
|
})
|
|
);
|
|
|
|
const allItems = computed(() =>
|
|
props.visibleContactIds.map(id => ({
|
|
id,
|
|
}))
|
|
);
|
|
|
|
const selectionModel = computed({
|
|
get: () => new Set(props.selectedContactIds),
|
|
set: newSet => {
|
|
if (!props.visibleContactIds.length) {
|
|
emit('toggleAll', false);
|
|
return;
|
|
}
|
|
|
|
const shouldSelectAll = props.visibleContactIds.every(id => newSet.has(id));
|
|
emit('toggleAll', shouldSelectAll);
|
|
},
|
|
});
|
|
|
|
const emitClearSelection = () => {
|
|
showLabelSelector.value = false;
|
|
emit('clearSelection');
|
|
};
|
|
|
|
const toggleLabelSelector = () => {
|
|
if (!selectedCount.value || props.isLoading) return;
|
|
showLabelSelector.value = !showLabelSelector.value;
|
|
};
|
|
|
|
const closeLabelSelector = () => {
|
|
showLabelSelector.value = false;
|
|
};
|
|
|
|
const handleAssignLabels = labels => {
|
|
emit('assignLabels', labels);
|
|
closeLabelSelector();
|
|
};
|
|
</script>
|
|
|
|
<template>
|
|
<div
|
|
class="sticky top-0 z-10 bg-gradient-to-b from-n-surface-1 from-90% to-transparent pt-1 pb-2"
|
|
>
|
|
<BulkSelectBar
|
|
v-model="selectionModel"
|
|
:all-items="allItems"
|
|
:select-all-label="selectAllLabel"
|
|
:selected-count-label="selectedCountLabel"
|
|
class="py-2 ltr:!pr-3 rtl:!pl-3 justify-between"
|
|
>
|
|
<template #secondary-actions>
|
|
<Button
|
|
sm
|
|
ghost
|
|
slate
|
|
:label="t('CONTACTS_BULK_ACTIONS.CLEAR_SELECTION')"
|
|
class="!px-1.5"
|
|
@click="emitClearSelection"
|
|
/>
|
|
</template>
|
|
<template #actions>
|
|
<div class="flex items-center gap-2 ml-auto">
|
|
<div
|
|
v-on-click-outside="closeLabelSelector"
|
|
class="relative flex items-center"
|
|
>
|
|
<Button
|
|
sm
|
|
faded
|
|
slate
|
|
icon="i-lucide-tags"
|
|
:label="t('CONTACTS_BULK_ACTIONS.ASSIGN_LABELS')"
|
|
:disabled="!selectedCount || isLoading"
|
|
:is-loading="isLoading"
|
|
class="[&>span:nth-child(2)]:hidden sm:[&>span:nth-child(2)]:inline w-fit"
|
|
@click="toggleLabelSelector"
|
|
/>
|
|
<transition
|
|
enter-active-class="transition ease-out duration-100"
|
|
enter-from-class="transform opacity-0 scale-95"
|
|
enter-to-class="transform opacity-100 scale-100"
|
|
leave-active-class="transition ease-in duration-75"
|
|
leave-from-class="transform opacity-100 scale-100"
|
|
leave-to-class="transform opacity-0 scale-95"
|
|
>
|
|
<LabelActions
|
|
v-if="showLabelSelector"
|
|
class="[&>.triangle]:!hidden [&>div>button]:!hidden ltr:!right-0 rtl:!left-0 top-8 mt-0.5"
|
|
@assign="handleAssignLabels"
|
|
/>
|
|
</transition>
|
|
</div>
|
|
<Policy :permissions="['administrator']">
|
|
<Button
|
|
v-tooltip.bottom="t('CONTACTS_BULK_ACTIONS.DELETE_CONTACTS')"
|
|
sm
|
|
faded
|
|
ruby
|
|
icon="i-lucide-trash"
|
|
:label="t('CONTACTS_BULK_ACTIONS.DELETE_CONTACTS')"
|
|
:aria-label="t('CONTACTS_BULK_ACTIONS.DELETE_CONTACTS')"
|
|
:disabled="!selectedCount || isLoading"
|
|
:is-loading="isLoading"
|
|
class="!px-1.5 [&>span:nth-child(2)]:hidden"
|
|
@click="emit('deleteSelected')"
|
|
/>
|
|
</Policy>
|
|
</div>
|
|
</template>
|
|
</BulkSelectBar>
|
|
</div>
|
|
</template>
|