iachat/app
Shivam Mishra e0ef007047
fix: Fix Sentry issues from Vite migration (#10262)
Fixes the following issues

- https://chatwoot-p3.sentry.io/issues/5966466083
- https://chatwoot-p3.sentry.io/issues/5966497518
- https://chatwoot-p3.sentry.io/issues/5966555379

For the first one, I am not sure if the fix is 100% correct, since I was
not able to reproduce, but I am confident it will work.

For both, 1st and 2nd issues, the problem came from the fact that we set
individual records to `undefined` when the intent was to remove it,
explicitly using delete fixes the issue.

### Whats up with the store changes?

Glad you asked, this comes down to Vue reactivity, previously Vue didn't
track undefined strictly, it just kinda ignored it, in Vue 3, the
reactivity changed significantly when they introduced ES6 proxies. The
Proxy tracks all property changes, including those set to undefined, so
properties remain enumerable.

So to delete a record, we actually have to the delete it using the
delete keyword, or replace the parent object with a new object splicing
the object to be deleted out.

I am assuming it worked earlier because VueX 3 reactivity was using
Object.defineProperty. Setting it to undefined might have "deleted" it
earlier

---------

Co-authored-by: Pranav <pranav@chatwoot.com>
2024-10-14 10:44:59 -07:00
..
actions fix: downcase email before finding (#8921) 2024-02-21 18:51:00 +05:30
assets feat: Vite + vue 3 💚 (#10047) 2024-10-02 00:36:30 -07:00
builders fix: default return in blocked domains (#10046) 2024-08-29 15:36:57 +05:30
channels chore: Sentry issues (#4623) 2022-05-06 14:50:55 +05:30
controllers feat: use of imap login as default if present (#10249) 2024-10-09 15:01:11 +05:30
dashboards feat: Super admin design improvements (#8517) 2023-12-08 19:40:35 -08:00
dispatchers fix: assignee_changed callback not getting triggered during conversation creation (#9334) 2024-05-06 11:48:17 -07:00
drops feat: Add the support for custom attributes in message variables (#8511) 2023-12-08 14:13:35 -08:00
fields feat: Supports masking tokens in super admin (#6491) 2023-02-21 17:50:55 +05:30
finders feat: Conversation API to return applied_sla and sla_events (#9174) 2024-04-01 23:30:07 +05:30
helpers feat: Improve Report API performance (#9476) 2024-05-22 17:34:24 -07:00
javascript fix: Fix Sentry issues from Vite migration (#10262) 2024-10-14 10:44:59 -07:00
jobs feat: Integration with Captain (alpha) (#9834) 2024-07-25 14:24:04 -07:00
listeners fix: Use message sender ID in the analytics for first response time (#9605) 2024-06-06 20:20:35 -07:00
mailboxes chore: Stop processing auto-response emails (#9606) 2024-06-13 14:19:11 -07:00
mailers feat: add Google Email fetch and OAuth token refresh service (#9603) 2024-06-11 14:22:03 +05:30
models feat: Show re-auth flag only for legacy Gmail and OAuth channels (#10189) 2024-10-02 00:51:02 -07:00
policies chore: Custom Roles to manage permissions [ UI ] (#9865) 2024-09-17 11:40:11 -07:00
presenters fix: last_activity_at is nil when conv is created (#9934) 2024-08-12 15:15:49 +05:30
services chore: Move line attachment creation to a single db commit (#10194) 2024-10-03 22:13:41 -07:00
views feat: Show re-auth flag only for legacy Gmail and OAuth channels (#10189) 2024-10-02 00:51:02 -07:00
workers fix: Capture delivery errors to avoid false positives (#8790) 2024-01-26 14:22:18 +04:00