224b1f98b0
## Description The IMAP email fetch job (Inboxes::FetchImapEmailsJob) crashes with an unhandled IOError: closed stream when the mail server's SSL socket is closed mid-write during Net::IMAP#fetch. This error was being reported to Sentry because the rescue clause only caught EOFError, not its parent class IOError. Fixes [CW-6689](https://linear.app/chatwoot/issue/CW-6689/ioerror-closed-stream-ioerror) Widened the rescue in fetch_imap_emails_job.rb from EOFError to IOError. In Ruby's exception hierarchy, EOFError is a subclass of IOError: ``` StandardError └── IOError └── EOFError ``` The Sentry stacktrace shows a plain IOError: closed stream raised from OpenSSL::Buffering#do_write → Net::IMAP#put_string → Net::IMAP#fetch. Since this is an IOError (not EOFError), it bypassed the existing rescue and fell through to the StandardError catch-all, which reported it to Sentry as an unhandled exception. Rescuing IOError now catches both: IOError: closed stream — the reported crash (parent class) EOFError — the previously handled case (still caught as a subclass) ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
55 lines
2.2 KiB
Ruby
55 lines
2.2 KiB
Ruby
require 'net/imap'
|
|
|
|
class Inboxes::FetchImapEmailsJob < MutexApplicationJob
|
|
queue_as :scheduled_jobs
|
|
|
|
def perform(channel, interval = 1)
|
|
return unless should_fetch_email?(channel)
|
|
|
|
key = format(::Redis::Alfred::EMAIL_MESSAGE_MUTEX, inbox_id: channel.inbox.id)
|
|
|
|
with_lock(key, 5.minutes) do
|
|
process_email_for_channel(channel, interval)
|
|
end
|
|
rescue *ExceptionList::IMAP_EXCEPTIONS => e
|
|
Rails.logger.error "Authorization error for email channel - #{channel.inbox.id} : #{e.message}"
|
|
rescue IOError, OpenSSL::SSL::SSLError, Net::IMAP::NoResponseError, Net::IMAP::BadResponseError, Net::IMAP::InvalidResponseError,
|
|
Net::IMAP::ResponseParseError, Net::IMAP::ResponseReadError, Net::IMAP::ResponseTooLargeError => e
|
|
Rails.logger.error "Error for email channel - #{channel.inbox.id} : #{e.message}"
|
|
rescue LockAcquisitionError
|
|
Rails.logger.error "Lock failed for #{channel.inbox.id}"
|
|
rescue StandardError => e
|
|
ChatwootExceptionTracker.new(e, account: channel.account).capture_exception
|
|
end
|
|
|
|
private
|
|
|
|
def should_fetch_email?(channel)
|
|
channel.imap_enabled? && !channel.reauthorization_required?
|
|
end
|
|
|
|
def process_email_for_channel(channel, interval)
|
|
inbound_emails = if channel.microsoft?
|
|
Imap::MicrosoftFetchEmailService.new(channel: channel, interval: interval).perform
|
|
elsif channel.google?
|
|
Imap::GoogleFetchEmailService.new(channel: channel, interval: interval).perform
|
|
else
|
|
Imap::FetchEmailService.new(channel: channel, interval: interval).perform
|
|
end
|
|
inbound_emails.map do |inbound_mail|
|
|
process_mail(inbound_mail, channel)
|
|
end
|
|
rescue OAuth2::Error => e
|
|
Rails.logger.error "Error for email channel - #{channel.inbox.id} : #{e.message}"
|
|
channel.authorization_error!
|
|
end
|
|
|
|
def process_mail(inbound_mail, channel)
|
|
Imap::ImapMailbox.new.process(inbound_mail, channel)
|
|
rescue StandardError => e
|
|
ChatwootExceptionTracker.new(e, account: channel.account).capture_exception
|
|
Rails.logger.error("
|
|
#{channel.provider} Email dropped: #{inbound_mail.from} and message_source_id: #{inbound_mail.message_id}")
|
|
end
|
|
end
|