* feat: Adds model for scheduling messages * feat: Implement scheduled message handling and processing jobs * feat: Add ScheduledMessagesController and associated specs for managing scheduled messages * refactor: Simplify scheduled message job specs and improve metadata handling * feat: Add ScheduledMessagePolicy for managing access to scheduled messages * feat: Add routes for managing scheduled messages * feat: Add scheduled message event handling and broadcasting * feat: Add JSON views for scheduled messages creation, destruction, updating, and indexing * feat: Update scheduled message status and dispatch update event after message creation * feat: Ensure scheduled message updates trigger dispatch event * feat: Add mutation types for managing scheduled messages * feat: Add additionalAttributes prop to Message component and provider * feat: Implement scheduled message handling in ActionCable and Vuex store * feat: Add unit tests for scheduled messages actions and mutations * feat: implement scheduled messages functionality - Added support for scheduling messages in the conversation dashboard. - Introduced new components: ScheduledMessageModal and ScheduledMessages for managing scheduled messages. - Enhanced ReplyBottomPanel to include scheduling options. - Updated Base.vue to handle scheduled message styling. - Integrated Vuex store module for managing scheduled messages state. - Added necessary translations for scheduled messages in English and Portuguese. * feat: add pagination to scheduled messages index and update tests accordingly * chore: update scheduled messages specs for future time validation and response status * chore: enhance scheduled messages API with pagination and add skeleton loader component * feat: add create_scheduled_message action to automation rule attributes * feat: implement create_scheduled_message action and enhance attachment handling * feat: add scheduled message functionality with UI components and localization * test: enhance scheduledMessages mutations tests with meta handling and structure * chore: update label to display file name upon successful upload in AutomationFileInput component * feat: add initialAttachment prop to ScheduledMessageModal and update ReplyBox to pass attachment * chore: prepend_mod_with to ScheduledMessagesController for better module handling * fix: attachment visibility in ScheduledMessageItem component * chore: enhance ScheduledMessage model with validations and reduce controller load * refactor: simplify ScheduledMessagesAPI methods by removing unnecessary instance variable * chore: update event emission for scheduled message creation in ReplyBox and ScheduledMessageModal * refactor: update status configuration to use label keys * chore: update date formatting in ScheduledMessageItem component * refactor: collapse logic to checkOverflow and update related functionality * chore: add author indication for current user in scheduled messages * chore: enhance scheduled message metadata with author information and localization * fix: send message shortcut * chore: handle errors in scheduled message submission * chore: update scheduled message modal to use combined date and time input * chore: refactor scheduled messages handling to remove pagination and update related tests * fix: ensure scheduled messages update status and dispatch on failure * fix: update scheduled message due date logic and simplify sending checks * refactor: rename build_message method for send_message * fix: update scheduled message creation time and improve test reliability * chore: ignore unnecessary check * chore: add scheduled message metadata handling in message builder, add scheduled message factorie and update specs * refactor: use scheduled message factorie creation in specs * chore: streamline error handling in scheduled message job and remove dispatch logic * fix: change scheduled_messages association to destroy dependent records * refactor: remove unused attributes from scheduled message payload builder * chore: update scheduled message retrieval to use conversation association * chore: correct cron format for scheduled messages job * chore: remove migration for author_type in scheduled_messages * feat: enhance scheduled messages management with delete confirmation and error handling * chore: set cron poll interval to 10 seconds for improved scheduling precision * feat: include additional_attributes in message JSON response * feat: enhance scheduled message validation and localization support * chore: update scheduled message display * Merge branch 'main' into Cayo-Oliveira/CU-86aenh268/Mensagens-agendadas * feat: add scheduled message indicators and validation for message length * fix: remove unnecessary condition from line-clamp class binding * feat: update scheduled messages localization and enhance content validation * feat: update scheduled messages order, enhance scheduledAt computation, and add message association * fix: reorder condition for Facebook channel message length computation * fix: change detection for attachments in scheduled messages * fix: remove unnecessary colon from close-on-backdrop-click prop in ScheduledMessageModal * chore: add error handling for scheduled message deletion and update localization for delete failure * fix: enforce minimum delay of 1 minute for scheduled messages and update validation * fix: remove unused private property and improve locale formatting for scheduled messages * fix: adjust positioning of DropdownBody in ReplyBottomPanel and clean up schema foreign keys * docs: add scheduled messages management APIs and payload definitions --------- Co-authored-by: gabrieljablonski <contact@gabrieljablonski.com>
239 lines
8.4 KiB
Ruby
239 lines
8.4 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe ScheduledMessage, type: :model do
|
|
let(:account) { create(:account) }
|
|
let(:author) { create(:user, account: account) }
|
|
let(:automation_rule) { create(:automation_rule, account: account) }
|
|
let(:inbox) { create(:inbox, account: account) }
|
|
let(:contact) { create(:contact, account: account) }
|
|
let(:contact_inbox) { create(:contact_inbox, contact: contact, inbox: inbox) }
|
|
let(:conversation) { create(:conversation, account: account, inbox: inbox, contact: contact, contact_inbox: contact_inbox) }
|
|
|
|
def build_scheduled_message(attrs = {})
|
|
ScheduledMessage.new({
|
|
account: account,
|
|
inbox: inbox,
|
|
conversation: conversation,
|
|
author: author,
|
|
content: 'Hello',
|
|
status: :pending,
|
|
scheduled_at: 1.hour.from_now
|
|
}.merge(attrs))
|
|
end
|
|
|
|
def create_scheduled_message(attrs = {})
|
|
build_scheduled_message(attrs).tap(&:save!)
|
|
end
|
|
|
|
describe 'validations' do
|
|
describe 'content' do
|
|
it 'requires content when no template params or attachment' do
|
|
scheduled_message = build_scheduled_message(content: nil, template_params: {})
|
|
|
|
expect(scheduled_message).not_to be_valid
|
|
expect(scheduled_message.errors[:content]).to be_present
|
|
end
|
|
|
|
it 'allows template params without content' do
|
|
scheduled_message = build_scheduled_message(content: nil, template_params: { id: '123456789', name: 'test_template' })
|
|
|
|
expect(scheduled_message).to be_valid
|
|
end
|
|
|
|
it 'allows attachment without content' do
|
|
scheduled_message = build_scheduled_message(content: nil, template_params: {})
|
|
scheduled_message.attachment.attach(
|
|
io: Rails.root.join('spec/assets/avatar.png').open,
|
|
filename: 'avatar.png',
|
|
content_type: 'image/png'
|
|
)
|
|
|
|
expect(scheduled_message).to be_valid
|
|
end
|
|
end
|
|
|
|
describe 'author' do
|
|
it 'accepts automation rules as author' do
|
|
scheduled_message = build_scheduled_message(author: automation_rule)
|
|
|
|
expect(scheduled_message).to be_valid
|
|
end
|
|
end
|
|
|
|
describe 'status on create' do
|
|
it 'allows creating with draft status' do
|
|
scheduled_message = build_scheduled_message(status: :draft, scheduled_at: nil)
|
|
|
|
expect(scheduled_message).to be_valid
|
|
end
|
|
|
|
it 'allows creating with pending status' do
|
|
scheduled_message = build_scheduled_message
|
|
|
|
expect(scheduled_message).to be_valid
|
|
end
|
|
|
|
it 'does not allow creating with sent status' do
|
|
scheduled_message = build_scheduled_message(status: :sent)
|
|
|
|
expect(scheduled_message).not_to be_valid
|
|
expect(scheduled_message.errors[:status]).to be_present
|
|
end
|
|
|
|
it 'does not allow creating with failed status' do
|
|
scheduled_message = build_scheduled_message(status: :failed)
|
|
|
|
expect(scheduled_message).not_to be_valid
|
|
expect(scheduled_message.errors[:status]).to be_present
|
|
end
|
|
end
|
|
|
|
describe 'scheduled_at' do
|
|
it 'requires scheduled_at when status is pending' do
|
|
scheduled_message = build_scheduled_message(status: :pending, scheduled_at: nil)
|
|
|
|
expect(scheduled_message).not_to be_valid
|
|
expect(scheduled_message.errors[:scheduled_at]).to be_present
|
|
end
|
|
|
|
it 'does not require scheduled_at when status is draft' do
|
|
scheduled_message = build_scheduled_message(status: :draft, scheduled_at: nil)
|
|
|
|
expect(scheduled_message).to be_valid
|
|
end
|
|
|
|
it 'requires scheduled_at to be in the future when pending' do
|
|
scheduled_message = build_scheduled_message(status: :pending, scheduled_at: 1.minute.ago)
|
|
|
|
expect(scheduled_message).not_to be_valid
|
|
expect(scheduled_message.errors[:scheduled_at]).to include('must be in the future')
|
|
end
|
|
|
|
it 'validates future scheduled_at when changing status to pending' do
|
|
scheduled_message = create_scheduled_message(status: :draft, scheduled_at: nil)
|
|
scheduled_message.status = :pending
|
|
scheduled_message.scheduled_at = 1.minute.ago
|
|
|
|
expect(scheduled_message).not_to be_valid
|
|
expect(scheduled_message.errors[:scheduled_at]).to include('must be in the future')
|
|
end
|
|
end
|
|
|
|
describe 'editability' do
|
|
it 'allows editing draft messages' do
|
|
scheduled_message = create_scheduled_message(status: :draft, scheduled_at: nil)
|
|
scheduled_message.content = 'Updated content'
|
|
|
|
expect(scheduled_message).to be_valid
|
|
end
|
|
|
|
it 'allows editing pending messages' do
|
|
scheduled_message = create_scheduled_message
|
|
scheduled_message.content = 'Updated content'
|
|
|
|
expect(scheduled_message).to be_valid
|
|
end
|
|
|
|
it 'does not allow editing content of sent messages' do
|
|
scheduled_message = create_scheduled_message
|
|
scheduled_message.update!(status: :sent)
|
|
|
|
expect { scheduled_message.update!(content: 'Updated content') }.to raise_error(ActiveRecord::RecordInvalid) do |error|
|
|
expect(error.record.errors[:base]).to include('Scheduled message can only be modified while draft or pending')
|
|
end
|
|
end
|
|
|
|
it 'does not allow editing content of failed messages' do
|
|
scheduled_message = create_scheduled_message
|
|
scheduled_message.update!(status: :failed)
|
|
|
|
expect { scheduled_message.update!(content: 'Updated content') }.to raise_error(ActiveRecord::RecordInvalid) do |error|
|
|
expect(error.record.errors[:base]).to include('Scheduled message can only be modified while draft or pending')
|
|
end
|
|
end
|
|
|
|
it 'allows changing status from sent to failed' do
|
|
scheduled_message = create_scheduled_message
|
|
scheduled_message.update!(status: :sent)
|
|
|
|
expect { scheduled_message.update!(status: :failed) }.not_to raise_error
|
|
expect(scheduled_message.reload.status).to eq('failed')
|
|
end
|
|
|
|
it 'allows changing status from failed to sent' do
|
|
scheduled_message = create_scheduled_message
|
|
scheduled_message.update!(status: :failed)
|
|
|
|
expect { scheduled_message.update!(status: :sent) }.not_to raise_error
|
|
expect(scheduled_message.reload.status).to eq('sent')
|
|
end
|
|
end
|
|
|
|
describe 'destroy' do
|
|
it 'allows deleting draft messages' do
|
|
scheduled_message = create_scheduled_message(status: :draft, scheduled_at: nil)
|
|
|
|
expect { scheduled_message.destroy }.to change(described_class, :count).by(-1)
|
|
end
|
|
|
|
it 'allows deleting pending messages' do
|
|
scheduled_message = create_scheduled_message
|
|
|
|
expect { scheduled_message.destroy }.to change(described_class, :count).by(-1)
|
|
end
|
|
|
|
it 'does not allow deleting sent messages' do
|
|
scheduled_message = create_scheduled_message
|
|
scheduled_message.update!(status: :sent)
|
|
|
|
expect { scheduled_message.destroy }.not_to change(described_class, :count)
|
|
expect(scheduled_message.errors[:base]).to include('Cannot delete a scheduled message that has already been sent or failed')
|
|
end
|
|
|
|
it 'does not allow deleting failed messages' do
|
|
scheduled_message = create_scheduled_message
|
|
scheduled_message.update!(status: :failed)
|
|
|
|
expect { scheduled_message.destroy }.not_to change(described_class, :count)
|
|
expect(scheduled_message.errors[:base]).to include('Cannot delete a scheduled message that has already been sent or failed')
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '.due_for_sending' do
|
|
it 'returns only pending messages scheduled up to the current minute' do
|
|
freeze_time
|
|
|
|
due_same_minute = create_scheduled_message(
|
|
scheduled_at: 1.minute.from_now
|
|
)
|
|
overdue = create_scheduled_message(
|
|
scheduled_at: 2.minutes.from_now
|
|
)
|
|
create_scheduled_message(
|
|
content: 'Future message',
|
|
scheduled_at: 10.minutes.from_now
|
|
)
|
|
create_scheduled_message(
|
|
scheduled_at: 1.minute.from_now,
|
|
status: :draft
|
|
)
|
|
|
|
sent_message = create_scheduled_message(
|
|
scheduled_at: 1.minute.from_now
|
|
)
|
|
sent_message.update!(status: :sent)
|
|
|
|
failed_message = create_scheduled_message(
|
|
scheduled_at: 1.minute.from_now
|
|
)
|
|
failed_message.update!(status: :failed)
|
|
|
|
# NOTE: Travel to a time where due_same_minute and overdue are due but not_due_yet is not
|
|
travel_to(5.minutes.from_now)
|
|
|
|
expect(described_class.due_for_sending).to contain_exactly(due_same_minute, overdue)
|
|
end
|
|
end
|
|
end
|