rodrigo/iachat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix(merge): CI offenses missed by pre-commit hook

Browse Source 
- Editor.vue: consolidate duplicate defineExpose() calls introduced when
  removing signature functions (broke Vite build, cascaded into super_admin
  request specs via ActionView::Template::Error)
- omniauth_callbacks_controller + backfill migration: Rails/SaveBang
  autocorrect (offenses live in unchanged upstream files, so pre-commit
  hook skipped them; CI runs rubocop project-wide)
This commit is contained in:
gabrieljablonski 2026-04-17 16:40:00 -03:00
parent 112385fd9e
commit 4d155e4c01
3 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/devise_overrides/omniauth_callbacks_controller.rb
View File

@ -96,7 +96,7 @@ class DeviseOverrides::OmniauthCallbacksController < DeviseTokenAuth::OmniauthCa
def set_random_password_if_oauth_user def set_random_password_if_oauth_user
# Password must satisfy secure_password requirements (uppercase, lowercase, number, special char) # Password must satisfy secure_password requirements (uppercase, lowercase, number, special char)
@resource.update(password: "#{SecureRandom.hex(16)}aA1!") if @resource.persisted? @resource.update!(password: "#{SecureRandom.hex(16)}aA1!") if @resource.persisted?
end end
def default_devise_mapping def default_devise_mapping

4
app/javascript/dashboard/components/widgets/WootWriter/Editor.vue
View File

@ -843,8 +843,6 @@ onMounted(() => {
} }
}); });
defineExpose({ focusEditorInputField });
// BUS Event to insert text or markdown into the editor at the // BUS Event to insert text or markdown into the editor at the
// current cursor position. // current cursor position.
// Components using this // Components using this
@ -865,7 +863,7 @@ function insertMentionTrigger(char) {
editorView.dispatch(tr); editorView.dispatch(tr);
} }
defineExpose({ insertMentionTrigger }); defineExpose({ focusEditorInputField, insertMentionTrigger });
</script> </script>
<template> <template>

4
db/migrate/20260320074636_backfill_feature_contact_attributes_for_assistants.rb
View File

@ -8,7 +8,7 @@ class BackfillFeatureContactAttributesForAssistants < ActiveRecord::Migration[7.
account.captain_assistants.each do |assistant| account.captain_assistants.each do |assistant|
next if assistant.feature_contact_attributes.present? next if assistant.feature_contact_attributes.present?
assistant.update(feature_contact_attributes: true) assistant.update!(feature_contact_attributes: true)
end end
end end
end end
@ -20,7 +20,7 @@ class BackfillFeatureContactAttributesForAssistants < ActiveRecord::Migration[7.
account.captain_assistants.each do |assistant| account.captain_assistants.each do |assistant|
next if assistant.feature_contact_attributes.blank? next if assistant.feature_contact_attributes.blank?
assistant.update(feature_contact_attributes: nil) assistant.update!(feature_contact_attributes: nil)
end end
end end
end end